Bug - If the only subscriber on a instance is banned, and unbanned, the unban doesn't federate to the instance.
-
hackertalks.com 0.19.11 - lone subscriber instance
lemmyworld.com 0.19.10 - ban and unban instance.
Single subscriber for a community gets banned, and a hour later gets unbanned. Since the subscriber is banned, the subscription appears to terminate. So there is no federation for the unban a hour later for that community.
note lemmy-federate doesn't subscribe if there is a local subscriber either.
Example community:
-
hackertalks.com 0.19.11 - lone subscriber instance
lemmyworld.com 0.19.10 - ban and unban instance.
Single subscriber for a community gets banned, and a hour later gets unbanned. Since the subscriber is banned, the subscription appears to terminate. So there is no federation for the unban a hour later for that community.
note lemmy-federate doesn't subscribe if there is a local subscriber either.
Example community:
Any way to force the federation of the unban later to get the instance to sync the current ban status?
-
Any way to force the federation of the unban later to get the instance to sync the current ban status?
the unban itself federates, but on community bans the user gets unsubscribed from the communities, which deletes the associated subscription in the db.
skimming over the code it seems to be only happening in case of community bans (including the ones derived from instance bans on 0.19), but it should also remove your local subscription on your own instance. as long as that federates it should still be picked up by lemmy-federate eventually, as your local instance should also have removed that when receiving the community ban.
it might be debatable whether subscriptions should get removed with community bans for public communities, but overall the code logic seems to be there. i haven't tested this end to end yet.
-
the unban itself federates, but on community bans the user gets unsubscribed from the communities, which deletes the associated subscription in the db.
skimming over the code it seems to be only happening in case of community bans (including the ones derived from instance bans on 0.19), but it should also remove your local subscription on your own instance. as long as that federates it should still be picked up by lemmy-federate eventually, as your local instance should also have removed that when receiving the community ban.
it might be debatable whether subscriptions should get removed with community bans for public communities, but overall the code logic seems to be there. i haven't tested this end to end yet.
This was fixed in a pr some time ago, though I don't have the link now.
